Gilad Chaplik has submitted this change and it was merged. Change subject: core: Renamed Refresh to refreshModel ......................................................................
core: Renamed Refresh to refreshModel Fixes FindBugs issues - 1. VERY confusing to have methods org.ovirt.engine.ui.uicommonweb.models.events.EventListModel.Refresh() and org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh() 2. VERY confusing to have methods org.ovirt.engine.ui.uicommonweb.models.templates.UserPortalTemplateEventListModel.Refresh() and org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh() 3. VERY confusing to have methods org.ovirt.engine.ui.uicommonweb.models.vms.UserPortalVmEventListModel.Refresh() and org.ovirt.engine.ui.uicommonweb.models.SearchableListModel.refresh() Base class of EventListModel already has a function named refresh() Since here the model is being refreshed ... called it refreshModel() Change-Id: I6d6b79a13fe9427253cdd2d93cd84c51e1574e0d Signed-off-by: Sharad Mishra <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/UserPortalTemplateEventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmEventListModel.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d6b79a13fe9427253cdd2d93cd84c51e1574e0d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
