Tomas Jelinek has uploaded a new change for review. Change subject: core: NPE on edit instance type ......................................................................
core: NPE on edit instance type No way to edit the instance type - a NPE was thrown in the UpdateVmTemplateCommand since instance type does not have a cluster. Change-Id: I83f9d02b3eb6e0562a6854c106f36bebc5bb4ffe Bug-Url: https://bugzilla.redhat.com/1209879 Signed-off-by: Tomas Jelinek <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/39812/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java index cb5dd64..37f04d8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java @@ -58,7 +58,7 @@ : Guid.Empty); } - Version compatibilityVersion = isBlankTemplate() ? Version.getLast() : getVdsGroup().getCompatibilityVersion(); + Version compatibilityVersion = isBlankTemplate() || isInstanceType() ? Version.getLast() : getVdsGroup().getCompatibilityVersion(); if (getVdsGroup() != null || isBlankTemplate()) { getVmPropertiesUtils().separateCustomPropertiesToUserAndPredefined(compatibilityVersion, parameters.getVmTemplateData()); -- To view, visit https://gerrit.ovirt.org/39812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I83f9d02b3eb6e0562a6854c106f36bebc5bb4ffe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
