Tal Nisan has posted comments on this change. Change subject: restapi: Show full Gluster storage domain details ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/39810/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java: Line 357: case FCP: Line 358: mapVolumeGroupFcp(model, entity); Line 359: break; Line 360: case NFS: Line 361: mapNFSProperties(model, entity); > It is very confusing to have a "case" without a "break". I can imagine myse See below Line 362: case LOCALFS: Line 363: case POSIXFS: Line 364: case GLUSTERFS: Line 365: mapFileDomain(model, entity); Line 380: } Line 381: if (cnx.getNfsVersion() != null) { Line 382: model.getStorage().setNfsVersion(StorageDomainMapper.map(cnx.getNfsVersion(), null)); Line 383: } Line 384: } > Do we really need this new method? Can't we have just one as before? Note t Can you look at patchset 1? We can change this class to how it look in patchset 1, is it acceptable by you? Line 385: Line 386: protected void mapFileDomain(StorageDomain model, Line 387: org.ovirt.engine.core.common.businessentities.StorageDomain entity) { Line 388: final Storage storage = model.getStorage(); https://gerrit.ovirt.org/#/c/39810/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java: Line 290: model.setMountOptions(entity.getMountOptions()); Line 291: } Line 292: } Line 293: else if (entity.getstorage_type().equals(org.ovirt.engine.core.common.businessentities.storage.StorageType.POSIXFS) Line 294: || entity.getstorage_type().equals(StorageType.GLUSTERFS)) { > Probably. Indeed, haven't noticed there is another StorageType, this is confusing Line 295: model.setMountOptions(entity.getMountOptions()); Line 296: model.setVfsType(entity.getVfsType()); Line 297: } Line 298: return model; -- To view, visit https://gerrit.ovirt.org/39810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2294ab6a0256f5c8bc5f48e04dada506500f79d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
