Ramesh N has posted comments on this change.

Change subject: webadmin: fix action availability for create brick
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39820/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java:

Line 207:             syncStorageDeviceAllowed = true;
Line 208:             createBrickAllowed = !getItems().isEmpty() && 
canCreateBrick();
Line 209:             if (createBrickAllowed && !getSelectedItems().isEmpty()) {
Line 210:                 for (StorageDevice device : getSelectedItems()) {
Line 211:                     if (device.getCanCreateBrick()) {
> Mutually exclusive canCreateBrick() and the condition above
Done.
Line 212:                         createBrickAllowed = false;
Line 213:                         break;
Line 214:                     }
Line 215: 


-- 
To view, visit https://gerrit.ovirt.org/39820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaff8f5863bd3107ba109e6f1f9d695d8ee67aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to