Moti Asayag has posted comments on this change. Change subject: core: [RFE]Backup Awareness - Handler ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/39527/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java: Line 30: private volatile boolean active; Line 31: @Inject Line 32: private AuditLogDirector auditLogDirector; Line 33: @Inject Line 34: EngineBackupLogDAO engineBackupLogDAO; private ? Line 35: Line 36: /** Line 37: * Initializes the backup h Check Manager Line 38: */ Line 78: auditLogDirector.log(alert, AuditLogType.ENGINE_NO_BACKUP); Line 79: } else { Line 80: //check time elapsed from last backup Line 81: Integer backupAlertPeriodInDays = Config.<Integer>getValue(ConfigValues.BackupAlertPeriodInDays); Line 82: Date dt = lastBackup.getDoneAt(); s/dt/lastBackupDate Line 83: long diffInDays = (Calendar.getInstance().getTimeInMillis() - dt.getTime()) / TimeUnit.DAYS.toMillis(1); Line 84: if (diffInDays > backupAlertPeriodInDays) { Line 85: alert.addCustomValue("Date", lastBackup.getDoneAt().toString()); Line 86: auditLogDirector.log(alert, AuditLogType.ENGINE_NO_WARM_BACKUP); Line 81: Integer backupAlertPeriodInDays = Config.<Integer>getValue(ConfigValues.BackupAlertPeriodInDays); Line 82: Date dt = lastBackup.getDoneAt(); Line 83: long diffInDays = (Calendar.getInstance().getTimeInMillis() - dt.getTime()) / TimeUnit.DAYS.toMillis(1); Line 84: if (diffInDays > backupAlertPeriodInDays) { Line 85: alert.addCustomValue("Date", lastBackup.getDoneAt().toString()); please reuse lastBackupDate variable from previous comment Line 86: auditLogDirector.log(alert, AuditLogType.ENGINE_NO_WARM_BACKUP); Line 87: } Line 88: } Line 89: -- To view, visit https://gerrit.ovirt.org/39527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8567ae314a3d612d8e3d4dd948394b65789ac670 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
