Allon Mureinik has posted comments on this change.
Change subject: core: cleanup IrsBrokerCommand
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 209: }
Line 210: });
Line 211: }
Line 212: }
Line 213: } catch (Exception ex) {
consider adding a log.error here?
Also, consider doing this in a separate patchset - it seems unrelated to the
rest of the patch.
Line 214: }
Line 215:
Line 216: }
Line 217:
--
To view, visit http://gerrit.ovirt.org/7962
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb9ffd3ea2c3449dea71d19aa35eec8c1640070
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
