Jakub Niedermertl has posted comments on this change.

Change subject: core: Vm Icons - backend part
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38600/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java:

Line 7: 
Line 8: /**
Line 9:  * Visual table viewer: http://jsfiddle.net/jniederm/u1bf0767/
Line 10:  */
Line 11: public interface VmIconDao extends GenericDao<VmIcon, Guid> {
> please create dao test class for this dao 
done https://gerrit.ovirt.org/#/c/39829/
Line 12: 
Line 13:     public List<VmIcon> getByDataUrl(String dataUrl);
Line 14: 
Line 15:     /**


-- 
To view, visit https://gerrit.ovirt.org/38600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98ad0d76285af3b2913e477a340bfd1ac09a296e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <[email protected]>
Gerrit-Reviewer: Anonymous Coward #1000711
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Jakub Niedermertl <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to