Allon Mureinik has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
......................................................................
Patch Set 15: Looks good to me, but someone else must approve
(1 inline comment)
Add the missing annotation, and we're good to go, IMHO.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
Line 34: protected boolean validateIsImagesOnDomains() {
Line 35: return true;
Line 36: }
Line 37:
Line 38: protected Map<String, String> getExclusiveLocks() {
This should have an @Override annotaion.
Line 39: Map<String, String> locks = new HashMap<String, String>();
Line 40: Map<String, String> parentLocks = super.getExclusiveLocks();
Line 41: if (parentLocks != null) {
Line 42: locks.putAll(parentLocks);
--
To view, visit http://gerrit.ovirt.org/8013
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5b6518bbf19077ae5822b9359a6147c87d0f46
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
