Liron Aravot has posted comments on this change. Change subject: core: ensure unique unit for VirtIO_SCSI and SPAR_VSCSI disks ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39471/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java: Line 173: @Override Line 174: public Void runInTransaction() { Line 175: VmDevice vmDevice = getParameters().getVmDevice(); Line 176: vmDevice.setAddress(address); Line 177: DbFacade.getInstance().getVmDeviceDao().update(vmDevice); we have a small gap here, if the hotplug fails this address will remain taken by that disk. on the other hand if the address will be cleared on failure if hotplug succeeds but the response doesn't return to the engine the address will be cleared, what will happen to new plugged disk on that scenario? will it be updated by the vdsupdateruntimeinfo flow? we need to do some checking on which option is better. Line 178: return null; Line 179: } Line 180: }); Line 181: } -- To view, visit https://gerrit.ovirt.org/39471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e621618e8891fca52b48bff437cc4c2a1f695db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
