Allon Mureinik has uploaded a new change for review. Change subject: webadmin: SearchSuggestionDisplay Findbugs ......................................................................
webadmin: SearchSuggestionDisplay Findbugs Fixed the FindBugs issue: "Possible null pointer dereference of suggestBox in org.ovirt.engine.ui.webadmin.widget.autocomplete. SearchSuggestionDisplay.showSuggestions (SuggestBox,Collection, boolean, boolean, SuggestBox$SuggestionCallback)" The addition of the autoHidePartner should be done inside the null-check, not after it. Change-Id: Iffde64f273f4a9bdfa2e61a280827f5b8f0e377b Signed-off-by: Allon Mureinik <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/8196/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java index 209bad6..7ed5c8c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java @@ -169,8 +169,8 @@ // If the suggest box has changed, free the old one first. if (suggestBox != null) { suggestionPopup.removeAutoHidePartner(suggestBox.getElement()); + suggestionPopup.addAutoHidePartner(suggestBox.getElement()); } - suggestionPopup.addAutoHidePartner(suggestBox.getElement()); // Create suggestions table widget suggestionsTable = -- To view, visit http://gerrit.ovirt.org/8196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iffde64f273f4a9bdfa2e61a280827f5b8f0e377b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
