Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Resizable columns in main tab grids
......................................................................
webadmin: Resizable columns in main tab grids
This patch enables column resizing for all main tab grids,
updating column widths as necessary.
Column widths were updated for 1280 x <height> layout.
In this layout, the sum of table column widths can take
up to ~1000 pixels before a horizontal scroll-bar is shown.
Note that some grids contain columns which don't fit into
above mentioned ~1000 pixel boundary, which means that
a horizontal scroll-bar is shown by default for such grids:
- Hosts
- Disks ('Images' and 'Direct LUN' options)
- Virtual Machines
- Events ('Advanced View' option)
Change-Id: I16973df7a28b972e6ef7987f72aabe729715584b
Bug-Url: https://bugzilla.redhat.com/767924
Signed-off-by: Vojtech Szocs <[email protected]>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
12 files changed, 147 insertions(+), 97 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/8199/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
index de56581..046857b 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
@@ -38,13 +38,15 @@
}
void initTable(ApplicationResources resources, ApplicationConstants
constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<VDSGroup> nameColumn = new
TextColumnWithTooltip<VDSGroup>() {
@Override
public String getValue(VDSGroup object) {
return object.getname();
}
};
- getTable().addColumn(nameColumn, constants.nameCluster());
+ getTable().addColumn(nameColumn, constants.nameCluster(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VDSGroup> versionColumn = new
TextColumnWithTooltip<VDSGroup>() {
@Override
@@ -52,7 +54,7 @@
return object.getcompatibility_version().getValue();
}
};
- getTable().addColumn(versionColumn, constants.comptVersCluster());
+ getTable().addColumn(versionColumn, constants.comptVersCluster(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<VDSGroup> descColumn = new
TextColumnWithTooltip<VDSGroup>() {
@Override
@@ -60,7 +62,7 @@
return object.getdescription();
}
};
- getTable().addColumn(descColumn, constants.descriptionCluster());
+ getTable().addColumn(descColumn, constants.descriptionCluster(),
"300px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<VDSGroup>(constants.newCluster()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java
index b9db1a5..d5d221a 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java
@@ -43,6 +43,8 @@
}
void initTable(ApplicationResources resources, ApplicationConstants
constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new DcStatusColumn(), constants.empty(), "30px");
//$NON-NLS-1$
TextColumnWithTooltip<storage_pool> nameColumn = new
TextColumnWithTooltip<storage_pool>() {
@@ -51,7 +53,7 @@
return object.getname();
}
};
- getTable().addColumn(nameColumn, constants.nameDc());
+ getTable().addColumn(nameColumn, constants.nameDc(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<storage_pool> storageTypeColumn = new
EnumColumn<storage_pool, StorageType>() {
@Override
@@ -59,7 +61,7 @@
return object.getstorage_pool_type();
}
};
- getTable().addColumn(storageTypeColumn, constants.storgeTypeDc());
+ getTable().addColumn(storageTypeColumn, constants.storgeTypeDc(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<storage_pool> statusColumn = new
EnumColumn<storage_pool, StoragePoolStatus>() {
@Override
@@ -67,7 +69,7 @@
return object.getstatus();
}
};
- getTable().addColumn(statusColumn, constants.statusDc());
+ getTable().addColumn(statusColumn, constants.statusDc(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<storage_pool> versionColumn = new
TextColumnWithTooltip<storage_pool>() {
@Override
@@ -75,7 +77,7 @@
return object.getcompatibility_version().getValue();
}
};
- getTable().addColumn(versionColumn, constants.comptVersDc());
+ getTable().addColumn(versionColumn, constants.comptVersDc(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<storage_pool> descColumn = new
TextColumnWithTooltip<storage_pool>() {
@Override
@@ -83,7 +85,7 @@
return object.getdescription();
}
};
- getTable().addColumn(descColumn, constants.descriptionDc());
+ getTable().addColumn(descColumn, constants.descriptionDc(), "300px");
//$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<storage_pool>(constants.newDC()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
index 1195d4f..10f281a 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
@@ -47,8 +47,7 @@
this.constants = constants;
this.commonModel = CommonModelManager.instance();
ViewIdHandler.idHandler.generateAndSetIds(this);
- initTableButtons();
- initTableOverhead();
+ initTable();
initWidget(getTable());
handleRadioButtonClick(null);
@@ -83,69 +82,81 @@
searchByDiskViewType(disksViewRadioGroup.getDiskStorageType());
getTable().ensureColumnPresent(
- DisksViewColumns.aliasColumn, constants.aliasDisk(), all ||
images || luns);
+ DisksViewColumns.aliasColumn, constants.aliasDisk(), all ||
images || luns,
+ "150px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.idColumn, constants.idDisk(), all || images
|| luns);
+ DisksViewColumns.idColumn, constants.idDisk(), all || images
|| luns,
+ "150px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.bootableDiskColumn, "", all || images ||
luns, "40px"); //$NON-NLS-1$ //$NON-NLS-2$
+ DisksViewColumns.bootableDiskColumn, "", all || images ||
luns, //$NON-NLS-1$
+ "30px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.shareableDiskColumn, "", all || images ||
luns, "40px"); //$NON-NLS-1$ //$NON-NLS-2$
+ DisksViewColumns.shareableDiskColumn, "", all || images ||
luns, //$NON-NLS-1$
+ "30px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunDiskColumn, "", all, "40px");
//$NON-NLS-1$ //$NON-NLS-2$
+ DisksViewColumns.lunDiskColumn, "", all, //$NON-NLS-1$
+ "30px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.diskContainersIconColumn, "", all || images
|| luns, "40px"); //$NON-NLS-1$ //$NON-NLS-2$
+ DisksViewColumns.diskContainersIconColumn, "", all || images
|| luns, //$NON-NLS-1$
+ "30px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.diskContainersColumn,
constants.attachedToDisk(), all || images || luns, "120px"); //$NON-NLS-1$
+ DisksViewColumns.diskContainersColumn,
constants.attachedToDisk(), all || images || luns,
+ "150px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.storageDomainsColumn,
constants.storageDomainsDisk(), images, "120px"); //$NON-NLS-1$
+ DisksViewColumns.storageDomainsColumn,
constants.storageDomainsDisk(), images,
+ "150px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.sizeColumn, constants.provisionedSizeDisk(),
all || images || luns, "100px"); //$NON-NLS-1$
+ DisksViewColumns.sizeColumn, constants.provisionedSizeDisk(),
all || images || luns,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.actualSizeColumn, constants.sizeDisk(),
images, "100px"); //$NON-NLS-1$
+ DisksViewColumns.actualSizeColumn, constants.sizeDisk(),
images,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.allocationColumn, constants.allocationDisk(),
images, "100px"); //$NON-NLS-1$
+ DisksViewColumns.allocationColumn, constants.allocationDisk(),
images,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.dateCreatedColumn,
constants.creationDateDisk(), images, "150px"); //$NON-NLS-1$
+ DisksViewColumns.dateCreatedColumn,
constants.creationDateDisk(), images,
+ "150px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.statusColumn, constants.statusDisk(), images,
"80px"); //$NON-NLS-1$
+ DisksViewColumns.statusColumn, constants.statusDisk(), images,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunIdColumn, constants.lunIdSanStorage(),
luns);
+ DisksViewColumns.lunIdColumn, constants.lunIdSanStorage(),
luns,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunSerialColumn,
constants.serialSanStorage(), luns);
+ DisksViewColumns.lunSerialColumn,
constants.serialSanStorage(), luns,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunVendorIdColumn,
constants.vendorIdSanStorage(), luns);
+ DisksViewColumns.lunVendorIdColumn,
constants.vendorIdSanStorage(), luns,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.lunProductIdColumn,
constants.productIdSanStorage(), luns);
+ DisksViewColumns.lunProductIdColumn,
constants.productIdSanStorage(), luns,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(
- DisksViewColumns.descriptionColumn,
constants.descriptionDisk(), all || images || luns);
-
+ DisksViewColumns.descriptionColumn,
constants.descriptionDisk(), all || images || luns,
+ "300px"); //$NON-NLS-1$
}
- void initTableOverhead() {
- disksViewRadioGroup = new DisksViewRadioGroup();
- disksViewRadioGroup.setClickHandler(clickHandler);
- getTable().setTableOverhead(disksViewRadioGroup);
- getTable().setTableTopMargin(20);
- }
+ void initTable() {
+ getTable().enableColumnResizing();
- void initTableButtons() {
getTable().addActionButton(new
WebAdminButtonDefinition<Disk>(constants.addDisk()) {
@Override
protected UICommand resolveCommand() {
@@ -180,6 +191,11 @@
return getMainModel().getChangeQuotaCommand();
}
});
+
+ disksViewRadioGroup = new DisksViewRadioGroup();
+ disksViewRadioGroup.setClickHandler(clickHandler);
+ getTable().setTableOverhead(disksViewRadioGroup);
+ getTable().setTableTopMargin(20);
}
void searchByDiskViewType(Object diskViewType) {
@@ -226,4 +242,5 @@
getMainModel().setSearchString(commonModel.getEffectiveSearchString());
getMainModel().Search();
}
+
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java
index 6170c39..24aee79 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java
@@ -65,28 +65,40 @@
boolean advancedViewEnabled = advancedViewButton.getValue();
getTable().ensureColumnPresent(AdvancedViewColumns.logTypeColumn,
constants.eventIdEvent(),
- advancedViewEnabled);
+ advancedViewEnabled,
+ "60px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.userColumn,
constants.userEvent(),
- advancedViewEnabled);
+ advancedViewEnabled,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.hostColumn,
constants.hostEvent(),
- advancedViewEnabled);
+ advancedViewEnabled,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.virtualMachineColumn,
constants.vmEvent(),
- advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly));
+ advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly),
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.templateColumn,
constants.templateEvent(),
- advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly));
+ advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly),
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.dataCenterColumn,
constants.dcEvent(),
- advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly));
+ advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly),
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.storageColumn,
constants.storageEvent(),
- advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly));
+ advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.VirtOnly),
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.clusterColumn,
constants.clusterEvent(),
- advancedViewEnabled);
+ advancedViewEnabled,
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.volumeColumn,
constants.volumeEvent(),
- advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.GlusterOnly));
+ advancedViewEnabled &&
ApplicationModeHelper.isModeSupported(ApplicationMode.GlusterOnly),
+ "100px"); //$NON-NLS-1$
getTable().ensureColumnPresent(AdvancedViewColumns.corrIdColumn,
constants.eventCorrelationId(),
- advancedViewEnabled);
+ advancedViewEnabled,
+ "100px"); //$NON-NLS-1$
}
void initTable() {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new AuditLogSeverityColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
TextColumnWithTooltip<AuditLog> logTimeColumn = new
FullDateTimeColumn<AuditLog>() {
@@ -95,7 +107,7 @@
return object.getlog_time();
}
};
- getTable().addColumn(logTimeColumn, constants.timeEvent(), "170px");
//$NON-NLS-1$
+ getTable().addColumn(logTimeColumn, constants.timeEvent(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<AuditLog> messageColumn = new
TextColumnWithTooltip<AuditLog>() {
@Override
@@ -103,7 +115,7 @@
return object.getmessage();
}
};
- getTable().addColumn(messageColumn, constants.messageEvent());
+ getTable().addColumn(messageColumn, constants.messageEvent(),
"150px"); //$NON-NLS-1$
}
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
index 64a564f..77ae5d9 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
@@ -86,6 +86,8 @@
}
void initTable() {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new HostStatusColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
TextColumnWithTooltip<VDS> nameColumn = new
TextColumnWithTooltip<VDS>() {
@@ -94,7 +96,7 @@
return object.getvds_name();
}
};
- getTable().addColumn(nameColumn, constants.nameHost());
+ getTable().addColumn(nameColumn, constants.nameHost(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VDS> hostColumn = new
TextColumnWithTooltip<VDS>() {
@Override
@@ -102,7 +104,7 @@
return object.gethost_name();
}
};
- getTable().addColumn(hostColumn, constants.ipHost());
+ getTable().addColumn(hostColumn, constants.ipHost(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VDS> clusterColumn = new
TextColumnWithTooltip<VDS>() {
@Override
@@ -110,7 +112,7 @@
return object.getvds_group_name();
}
};
- getTable().addColumn(clusterColumn, constants.clusterHost());
+ getTable().addColumn(clusterColumn, constants.clusterHost(), "150px");
//$NON-NLS-1$
if (ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly) {
TextColumnWithTooltip<VDS> dcColumn = new
TextColumnWithTooltip<VDS>() {
@@ -119,7 +121,7 @@
return object.getstorage_pool_name();
}
};
- getTable().addColumn(dcColumn, constants.dcHost());
+ getTable().addColumn(dcColumn, constants.dcHost(), "150px");
//$NON-NLS-1$
}
TextColumnWithTooltip<VDS> statusColumn = new EnumColumn<VDS,
VDSStatus>() {
@@ -128,7 +130,7 @@
return object.getstatus();
}
};
- getTable().addColumn(statusColumn, constants.statusHost());
+ getTable().addColumn(statusColumn, constants.statusHost(), "100px");
//$NON-NLS-1$
if (ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly) {
ProgressBarColumn<VDS> loadColumn = new ProgressBarColumn<VDS>() {
@@ -143,7 +145,7 @@
return object.getvm_active() != null ?
Math.min(object.getvm_active(), 100) : 0;
}
};
- getTable().addColumn(loadColumn, constants.loadHost(), "100px");
//$NON-NLS-1$
+ getTable().addColumn(loadColumn, constants.loadHost(), "80px");
//$NON-NLS-1$
}
PercentColumn<VDS> memColumn = new PercentColumn<VDS>() {
@@ -171,11 +173,9 @@
getTable().addColumn(netColumn, constants.networkHost(), "60px");
//$NON-NLS-1$
if (ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly) {
-
TextColumnWithTooltip<VDS> spmColumn = new
TextColumnWithTooltip<VDS>() {
@Override
public String getValue(VDS object) {
-
int value = object.getVdsSpmPriority();
int lowValue = defaultSpmPriority / 2;
int highValue = defaultSpmPriority + (maxSpmPriority -
defaultSpmPriority) / 2;
@@ -197,7 +197,7 @@
return constants.spmCustomText();
}
};
- getTable().addColumn(spmColumn, constants.spmPriorityHost(),
"80px"); //$NON-NLS-1$
+ getTable().addColumn(spmColumn, constants.spmPriorityHost(),
"100px"); //$NON-NLS-1$
}
getTable().addActionButton(new
WebAdminButtonDefinition<VDS>(constants.newHost()) {
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
index 713bb3b..677c1d1 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java
@@ -31,13 +31,15 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<vm_pools> nameColumn = new
TextColumnWithTooltip<vm_pools>() {
@Override
public String getValue(vm_pools object) {
return object.getvm_pool_name();
}
};
- getTable().addColumn(nameColumn, constants.namePool());
+ getTable().addColumn(nameColumn, constants.namePool(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<vm_pools> assignedColumn = new
TextColumnWithTooltip<vm_pools>() {
@Override
@@ -45,7 +47,7 @@
return Integer.toString(object.getvm_assigned_count());
}
};
- getTable().addColumn(assignedColumn, constants.assignVmsPool());
+ getTable().addColumn(assignedColumn, constants.assignVmsPool(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<vm_pools> runningColumn = new
TextColumnWithTooltip<vm_pools>() {
@Override
@@ -53,7 +55,7 @@
return Integer.toString(object.getvm_running_count());
}
};
- getTable().addColumn(runningColumn, constants.runningVmsPool());
+ getTable().addColumn(runningColumn, constants.runningVmsPool(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<vm_pools> typeColumn = new EnumColumn<vm_pools,
VmPoolType>() {
@Override
@@ -61,7 +63,7 @@
return object.getvm_pool_type();
}
};
- getTable().addColumn(typeColumn, constants.typePool());
+ getTable().addColumn(typeColumn, constants.typePool(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<vm_pools> descColumn = new
TextColumnWithTooltip<vm_pools>() {
@Override
@@ -69,7 +71,7 @@
return object.getvm_pool_description();
}
};
- getTable().addColumn(descColumn, constants.descriptionPool());
+ getTable().addColumn(descColumn, constants.descriptionPool(),
"300px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<vm_pools>(constants.newPool()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
index 059b9d4..7097d23 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
@@ -30,6 +30,8 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new QuotaDcStatusColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@@ -37,20 +39,22 @@
public String getValue(Quota object) {
return object.getQuotaName() == null ? "" :
object.getQuotaName(); //$NON-NLS-1$
}
- }, constants.nameQuota());
+ }, constants.nameQuota(), "150px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@Override
public String getValue(Quota object) {
return object.getDescription() == null ? "" :
object.getDescription(); //$NON-NLS-1$
}
- }, constants.descriptionQuota());
+ }, constants.descriptionQuota(), "300px"); //$NON-NLS-1$
+
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@Override
public String getValue(Quota object) {
return object.getStoragePoolName() == null ? "" :
object.getStoragePoolName(); //$NON-NLS-1$
}
- }, constants.dcQuota());
+ }, constants.dcQuota(), "150px"); //$NON-NLS-1$
+
// getTable().addColumn(new TextColumnWithTooltip<Quota>() {
// @Override
// public String getValue(Quota object) {
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
index e2f98a6..f8456c8 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
@@ -44,6 +44,8 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new StorageDomainSharedStatusColumn(),
constants.empty(), "30px"); //$NON-NLS-1$
TextColumnWithTooltip<storage_domains> nameColumn = new
TextColumnWithTooltip<storage_domains>() {
@@ -52,7 +54,7 @@
return object.getstorage_name();
}
};
- getTable().addColumn(nameColumn, constants.domainNameStorage());
+ getTable().addColumn(nameColumn, constants.domainNameStorage(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<storage_domains> domainTypeColumn = new
EnumColumn<storage_domains, StorageDomainType>() {
@Override
@@ -60,7 +62,7 @@
return object.getstorage_domain_type();
}
};
- getTable().addColumn(domainTypeColumn, constants.domainTypeStorage());
+ getTable().addColumn(domainTypeColumn, constants.domainTypeStorage(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<storage_domains> storageTypeColumn = new
EnumColumn<storage_domains, StorageType>() {
@Override
@@ -68,7 +70,7 @@
return object.getstorage_type();
}
};
- getTable().addColumn(storageTypeColumn,
constants.storageTypeStorage());
+ getTable().addColumn(storageTypeColumn,
constants.storageTypeStorage(), "150px"); //$NON-NLS-1$
TextColumnWithTooltip<storage_domains> formatColumn = new
EnumColumn<storage_domains, StorageFormatType>() {
@Override
@@ -76,7 +78,7 @@
return object.getStorageFormat();
}
};
- getTable().addColumn(formatColumn, constants.formatStorage());
+ getTable().addColumn(formatColumn, constants.formatStorage(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<storage_domains> crossDataCenterStatusColumn =
new EnumColumn<storage_domains, StorageDomainSharedStatus>() {
@@ -85,7 +87,7 @@
return object.getstorage_domain_shared_status();
}
};
- getTable().addColumn(crossDataCenterStatusColumn,
constants.crossDcStatusStorage());
+ getTable().addColumn(crossDataCenterStatusColumn,
constants.crossDcStatusStorage(), "150px"); //$NON-NLS-1$
DiskSizeColumn<storage_domains> freeSpaceColumn = new
DiskSizeColumn<storage_domains>(DiskSizeUnit.GIGABYTE) {
@Override
@@ -94,7 +96,7 @@
return (long) availableDiskSize;
}
};
- getTable().addColumn(freeSpaceColumn, constants.freeSpaceStorage());
+ getTable().addColumn(freeSpaceColumn, constants.freeSpaceStorage(),
"150px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<storage_domains>(constants.newDomainStorage()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
index 8aaebb8..fefd9d8 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
@@ -34,13 +34,15 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<VmTemplate> nameColumn = new
TextColumnWithTooltip<VmTemplate>() {
@Override
public String getValue(VmTemplate object) {
return object.getname();
}
};
- getTable().addColumn(nameColumn, constants.namePool());
+ getTable().addColumn(nameColumn, constants.namePool(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> domainColumn = new
TextColumnWithTooltip<VmTemplate>() {
@Override
@@ -48,7 +50,7 @@
return object.getdomain();
}
};
- getTable().addColumn(domainColumn, constants.domainTemplate());
+ getTable().addColumn(domainColumn, constants.domainTemplate(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> creationDateColumn = new
GeneralDateTimeColumn<VmTemplate>() {
@Override
@@ -56,7 +58,7 @@
return object.getcreation_date();
}
};
- getTable().addColumn(creationDateColumn,
constants.creationDateTemplate());
+ getTable().addColumn(creationDateColumn,
constants.creationDateTemplate(), "150px"); //$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> statusColumn = new
EnumColumn<VmTemplate, VmTemplateStatus>() {
@Override
@@ -64,7 +66,7 @@
return object.getstatus();
}
};
- getTable().addColumn(statusColumn, constants.statusTemplate());
+ getTable().addColumn(statusColumn, constants.statusTemplate(),
"100px"); //$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> clusterColumn = new
TextColumnWithTooltip<VmTemplate>() {
@Override
@@ -72,7 +74,7 @@
return object.getvds_group_name();
}
};
- getTable().addColumn(clusterColumn, constants.clusterTemplate());
+ getTable().addColumn(clusterColumn, constants.clusterTemplate(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> dcColumn = new
TextColumnWithTooltip<VmTemplate>() {
@Override
@@ -80,7 +82,7 @@
return object.getstorage_pool_name();
}
};
- getTable().addColumn(dcColumn, constants.dcTemplate());
+ getTable().addColumn(dcColumn, constants.dcTemplate(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> descriptionColumn = new
TextColumnWithTooltip<VmTemplate>() {
@Override
@@ -88,7 +90,7 @@
return object.getdescription();
}
};
- getTable().addColumn(descriptionColumn,
constants.descriptionTemplate());
+ getTable().addColumn(descriptionColumn,
constants.descriptionTemplate(), "150px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<VmTemplate>(constants.editTemplate()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
index 1741243..013c7c5 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
@@ -30,6 +30,8 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new UserStatusColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<DbUser>() {
@@ -37,35 +39,35 @@
public String getValue(DbUser object) {
return object.getname();
}
- }, constants.firstnameUser());
+ }, constants.firstnameUser(), "150px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<DbUser>() {
@Override
public String getValue(DbUser object) {
return object.getsurname();
}
- }, constants.lastNameUser());
+ }, constants.lastNameUser(), "150px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<DbUser>(40) {
@Override
public String getValue(DbUser object) {
return object.getusername();
}
- }, constants.userNameUser());
+ }, constants.userNameUser(), "150px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<DbUser>(40) {
@Override
public String getValue(DbUser object) {
return object.getgroups();
}
- }, constants.groupUser());
+ }, constants.groupUser(), "150px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<DbUser>() {
@Override
public String getValue(DbUser object) {
return object.getemail();
}
- }, constants.emailUser());
+ }, constants.emailUser(), "150px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<DbUser>(constants.addUser()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
index 62b6c1d..f7f9c4c 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
@@ -47,6 +47,8 @@
}
void initTable(ApplicationResources resources, ApplicationConstants
constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new VmStatusColumn(), constants.empty(), "30px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> nameColumn = new TextColumnWithTooltip<VM>()
{
@@ -57,7 +59,7 @@
};
getTable().addColumn(nameColumn, constants.nameVm(), "150px");
//$NON-NLS-1$
- getTable().addColumn(new VmTypeColumn(), constants.empty(), "40px");
//$NON-NLS-1$
+ getTable().addColumn(new VmTypeColumn(), constants.empty(), "30px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> clusterColumn = new
TextColumnWithTooltip<VM>() {
@Override
@@ -65,7 +67,7 @@
return object.getvds_group_name();
}
};
- getTable().addColumn(clusterColumn, constants.clusterVm(), "100px");
//$NON-NLS-1$
+ getTable().addColumn(clusterColumn, constants.clusterVm(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> dcColumn = new TextColumnWithTooltip<VM>() {
@Override
@@ -73,7 +75,7 @@
return object.getstorage_pool_name();
}
};
- getTable().addColumn(dcColumn, constants.dcVm(), "100px");
//$NON-NLS-1$
+ getTable().addColumn(dcColumn, constants.dcVm(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> hostColumn = new TextColumnWithTooltip<VM>()
{
@Override
@@ -81,7 +83,7 @@
return object.getrun_on_vds_name();
}
};
- getTable().addColumn(hostColumn, constants.hostVm(), "100px");
//$NON-NLS-1$
+ getTable().addColumn(hostColumn, constants.hostVm(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> ipColumn = new TextColumnWithTooltip<VM>() {
@Override
@@ -89,7 +91,7 @@
return object.getvm_ip();
}
};
- getTable().addColumn(ipColumn, constants.ipVm(), "100px");
//$NON-NLS-1$
+ getTable().addColumn(ipColumn, constants.ipVm(), "150px");
//$NON-NLS-1$
PercentColumn<VM> memoryColumn = new PercentColumn<VM>() {
@Override
@@ -129,7 +131,7 @@
return renderer.render(getRawValue(object));
}
};
- getTable().addColumn(displayColumn, constants.displayVm(), "70px");
//$NON-NLS-1$
+ getTable().addColumn(displayColumn, constants.displayVm(), "100px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> statusColumn = new EnumColumn<VM,
VMStatus>() {
@Override
@@ -137,7 +139,7 @@
return object.getstatus();
}
};
- getTable().addColumn(statusColumn, constants.statusVm(), "90px");
//$NON-NLS-1$
+ getTable().addColumn(statusColumn, constants.statusVm(), "100px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> uptimeColumn = new UptimeColumn<VM>() {
@Override
@@ -145,7 +147,7 @@
return object.getRoundedElapsedTime();
}
};
- getTable().addColumn(uptimeColumn, constants.uptimeVm(), "70px");
//$NON-NLS-1$
+ getTable().addColumn(uptimeColumn, constants.uptimeVm(), "100px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> loggedInUserColumn = new
TextColumnWithTooltip<VM>() {
@Override
@@ -156,7 +158,7 @@
return String.valueOf(object.getguest_cur_user_name());
}
};
- getTable().addColumn(loggedInUserColumn, constants.loggedInUserVm(),
"90px"); //$NON-NLS-1$
+ getTable().addColumn(loggedInUserColumn, constants.loggedInUserVm(),
"100px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<VM>(constants.newServerVm()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
index 290c804..2b9e84f 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
@@ -40,14 +40,17 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new VolumeStatusColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
+
TextColumnWithTooltip<GlusterVolumeEntity> nameColumn = new
TextColumnWithTooltip<GlusterVolumeEntity>() {
@Override
public String getValue(GlusterVolumeEntity object) {
return object.getName();
}
};
- getTable().addColumn(nameColumn, constants.NameVolume());
+ getTable().addColumn(nameColumn, constants.NameVolume(), "150px");
//$NON-NLS-1$
TextColumnWithTooltip<GlusterVolumeEntity> volumeTypeColumn =
new EnumColumn<GlusterVolumeEntity, GlusterVolumeType>() {
@@ -57,7 +60,7 @@
return object.getVolumeType();
}
};
- getTable().addColumn(volumeTypeColumn, constants.volumeTypeVolume());
+ getTable().addColumn(volumeTypeColumn, constants.volumeTypeVolume(),
"150px"); //$NON-NLS-1$
TextColumnWithTooltip<GlusterVolumeEntity> numOfBricksColumn =
new TextColumnWithTooltip<GlusterVolumeEntity>() {
@@ -66,7 +69,7 @@
return Integer.toString(object.getBricks().size());
}
};
- getTable().addColumn(numOfBricksColumn,
constants.numberOfBricksVolume());
+ getTable().addColumn(numOfBricksColumn,
constants.numberOfBricksVolume(), "150px"); //$NON-NLS-1$
TextColumnWithTooltip<GlusterVolumeEntity> transportColumn =
new TextColumnWithTooltip<GlusterVolumeEntity>() {
@@ -95,7 +98,7 @@
}
};
- getTable().addColumn(transportColumn,
constants.transportTypesVolume());
+ getTable().addColumn(transportColumn,
constants.transportTypesVolume(), "150px"); //$NON-NLS-1$
TextColumnWithTooltip<GlusterVolumeEntity> statusColumn =
new EnumColumn<GlusterVolumeEntity, GlusterStatus>() {
@@ -104,7 +107,7 @@
return object.getStatus();
}
};
- getTable().addColumn(statusColumn, constants.statusVolume());
+ getTable().addColumn(statusColumn, constants.statusVolume(), "150px");
//$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<GlusterVolumeEntity>(constants.createVolumeVolume()) {
@Override
--
To view, visit http://gerrit.ovirt.org/8199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16973df7a28b972e6ef7987f72aabe729715584b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
