Omer Frenkel has posted comments on this change. Change subject: backend: Add HostDev passthrough support #3 ......................................................................
Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/37619/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 239: try { Line 240: if (connectLunDisks(getVdsId())) { Line 241: status = createVm(); Line 242: ExecutionHandler.setAsyncJob(getExecutionContext(), true); Line 243: markHostDevicesAsUsed(); > Isn't ProceedDownVmCommand called in such cases? All hostdev deallocation i in case there is no exception, we dont call processDown because the vm wasn't even started, we call rerun, hence my other comment below in case we completely fail (also rerun fails) processVmOnDown is called Line 244: } Line 245: } catch(VdcBLLException e) { Line 246: // if the returned exception is such that shoudn't trigger the re-run process, Line 247: // re-throw it. otherwise, continue (the vm will be down and a re-run will be triggered) -- To view, visit https://gerrit.ovirt.org/37619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93c746cdda71678f7840d37683b890080a74341d Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
