Allon Mureinik has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 462: List<String> lockedDisksAliases = new ArrayList<String>();
Line 463: if (vm.getstatus() == VMStatus.ImageLocked) {
Line 464: ListUtils.nullSafeAdd(messages,
VdcBllMessages.ACTION_TYPE_FAILED_VM_IMAGE_IS_LOCKED.toString());
Line 465: returnValue = false;
Line 466: } else if (diskImageList != null) {
If the VM is in state IMAGE_LOCKED /AND/ has locked disks, I'd like the more
informative error message ACTION_TYPE_FAILED_DISKS_IMAGES_ARE_LOCKED
Line 467: for (Object object : diskImageList) {
Line 468: Disk disk = (Disk) object;
Line 469: if (DiskStorageType.IMAGE ==
disk.getDiskStorageType()
Line 470: && ((DiskImage) disk).getimageStatus() ==
ImageStatus.LOCKED) {
....................................................
Commit Message
Line 5: CommitDate: 2012-09-27 09:24:51 +0200
Line 6:
Line 7: core: Changed illegal error msg to locked(#840304)
Line 8:
Line 9: Replaced VM in illegal state error message to locked VM in:
s/://
Line 10: ImagesHandler.PerformImagesChecks() when the VM is indeed locked.
Line 11:
Line 12: The specific flow of actions to introduce the wrong message was:
Line 13: Try to export a VM while committing a preview.
Line 8:
Line 9: Replaced VM in illegal state error message to locked VM in:
Line 10: ImagesHandler.PerformImagesChecks() when the VM is indeed locked.
Line 11:
Line 12: The specific flow of actions to introduce the wrong message was:
s/://
Line 13: Try to export a VM while committing a preview.
Line 14: This yielded a statement that the VM's state is illegal while it should
Line 15: only say that it's locked.
Line 16: This should correct other flow of events as well.
--
To view, visit http://gerrit.ovirt.org/8078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
