Allon Mureinik has posted comments on this change. Change subject: core: QuotaStorageDependent removal in ExtendImageSizeCommand. ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Conceptually +2 - just add the details to the commit message. https://gerrit.ovirt.org/#/c/39866/1//COMMIT_MSG Commit Message: Line 11: in case the disk size is extended, but never reaches the actual consume Line 12: part in the code as it is constructed as an unquota-dependent command. Line 13: Line 14: Moreover, UpdateDiskCommand deals with any case of quota consumption so Line 15: dealing with that is not needed in that command. Please add a reference to the patch that introduced this new behavior in UpdateDiskCommand, and to the bug it solved. Line 16: Line 17: Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc -- To view, visit https://gerrit.ovirt.org/39866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
