Yevgeny Zaspitsky has uploaded a new change for review. Change subject: engine: add the proper message for not auth terminate session ......................................................................
engine: add the proper message for not auth terminate session Add proper message when a non-authorized user tries to terminate a user session. Change-Id: I4f4cdf735b3ce19c1ff8a2d13f083639a8f0445a Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/39890/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java index 15a6977..50027ee 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java @@ -12,6 +12,7 @@ import org.ovirt.engine.core.common.action.TerminateSessionParameters; import org.ovirt.engine.core.common.action.VdcActionParametersBase; import org.ovirt.engine.core.common.businessentities.aaa.DbUser; +import org.ovirt.engine.core.common.errors.VdcBllMessages; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.utils.linq.Predicate; @@ -60,7 +61,12 @@ @Override protected boolean isUserAuthorizedToRunAction() { - return isSystemSuperUserPredicate.eval(getCurrentUser().getId()); + if (isSystemSuperUserPredicate.eval(getCurrentUser().getId())) { + return true; + } else { + addCanDoActionMessage(VdcBllMessages.USER_NOT_AUTHORIZED_TO_PERFORM_ACTION); + return false; + } } @Override -- To view, visit https://gerrit.ovirt.org/39890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4f4cdf735b3ce19c1ff8a2d13f083639a8f0445a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
