Piotr Kliczewski has posted comments on this change. Change subject: construct jsonrpc with identifier name. ......................................................................
Patch Set 2: (1 comment) The change looks good please remove the empty lines. https://gerrit.ovirt.org/#/c/39888/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java: Line 55: clientPolicy.setIdentifier(hostname); Line 56: return createClient(hostname, port, connectionPolicy, clientPolicy, isSecure, type, protocol); Line 57: } Line 58: Line 59: Please remove those 2 extra empty lines. Line 60: Line 61: private static JsonRpcClient createClient(String hostname, Line 62: int port, Line 63: ClientPolicy connectionPolicy, -- To view, visit https://gerrit.ovirt.org/39888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic423322de3f1e0d1862d147a3b529f5c047d8b02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldad Marciano <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
