Kanagaraj M has posted comments on this change. Change subject: gluster: fix NPE in gluster sync job for volume capacity info ......................................................................
Patch Set 1: (1 comment) IIRC volumeAdavancedDetails contains the status of all bricks. If this is null, how the brick status is updated in engine? https://gerrit.ovirt.org/#/c/39968/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 1002: }); Line 1003: } Line 1004: Line 1005: private Map<Guid, BrickProperties> getBrickPropertiesMap(GlusterVolumeAdvancedDetails volumeDetails) { Line 1006: Map<Guid, BrickProperties> brickStatusMap = new HashMap<Guid, BrickProperties>(); NPE here as well? Line 1007: for (BrickDetails brickDetails : volumeDetails.getBrickDetails()) { Line 1008: if (brickDetails.getBrickProperties().getBrickId() != null) { Line 1009: brickStatusMap.put(brickDetails.getBrickProperties().getBrickId(), brickDetails.getBrickProperties()); Line 1010: } -- To view, visit https://gerrit.ovirt.org/39968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab4c5cdc38c53aa7b35417ad3db10b1cb4ac0f2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
