Sahina Bose has posted comments on this change. Change subject: engine: Fix unknown geo-rep session status ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/39869/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionStatusVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionStatusVDSCommand.java: Line 24: proceedProxyReturnValue(); Line 25: if (getVDSReturnValue().getSucceeded()) { Line 26: setReturnValue(result.getGeoRepDetails(parameter.getVolumeName(), Line 27: parameter.getSlaveHost(), Line 28: parameter.getSlaveVolume())); arguments required? Line 29: } Line 30: } Line 31: https://gerrit.ovirt.org/#/c/39869/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java: Line 59: arguments not required -- To view, visit https://gerrit.ovirt.org/39869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299ecbf2d66dc990acff8db1def250f615cc6279 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
