Maor Lipchuk has posted comments on this change. Change subject: core: CinderVolumeDriver enum ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39655/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderVolumeDriver.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderVolumeDriver.java: Line 21: return type; Line 22: } Line 23: } Line 24: return null; Line 25: } Consider to use static block for initializing mapping, so forValue will only be fetching it from the mapping instead use the for loop every time (see AsyncTaskStatusEnum for example) -- To view, visit https://gerrit.ovirt.org/39655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7775461446af0a725c24fc66d882342d3b38ceb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
