Shubhendu Tripathi has uploaded a new change for review. Change subject: webadmin: Show timezone dropdown for all cases ......................................................................
webadmin: Show timezone dropdown for all cases Modified the gluster volume snapshot scheduling dialog to show timezone dropdwon in all the valid recurrence type like - Minutely - Hourly - Daily - Weekly - Monthly Change-Id: Ic83e8d3a3d1505c09ab5f0d36c21b8ab1fa1d85d Signed-off-by: Shubhendu Tripathi <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java 2 files changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/40005/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java index 08ecd06..ccad0e1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java @@ -637,9 +637,7 @@ snapshotModel.getEndDate().setEntity(schedule.getEndByDate()); } - if (schedule.getRecurrence() == GlusterVolumeSnapshotScheduleRecurrence.DAILY - || schedule.getRecurrence() == GlusterVolumeSnapshotScheduleRecurrence.WEEKLY - || schedule.getRecurrence() == GlusterVolumeSnapshotScheduleRecurrence.MONTHLY) { + if (schedule.getRecurrence() != GlusterVolumeSnapshotScheduleRecurrence.UNKNOWN) { snapshotModel.getTimeZones().setSelectedItem(schedule.getTimeZone()); } switch (schedule.getRecurrence()) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java index c5b998b..8d3febb 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java @@ -221,9 +221,7 @@ intervalEditor.setVisible(recurrenceOption == GlusterVolumeSnapshotScheduleRecurrence.INTERVAL); endByOptionsEditor.setVisible(recurrenceOption != GlusterVolumeSnapshotScheduleRecurrence.UNKNOWN); - timeZoneEditor.setVisible(recurrenceOption == GlusterVolumeSnapshotScheduleRecurrence.DAILY - || recurrenceOption == GlusterVolumeSnapshotScheduleRecurrence.WEEKLY - || recurrenceOption == GlusterVolumeSnapshotScheduleRecurrence.MONTHLY); + timeZoneEditor.setVisible(recurrenceOption != GlusterVolumeSnapshotScheduleRecurrence.UNKNOWN); daysOfWeekEditor.setVisible(recurrenceOption == GlusterVolumeSnapshotScheduleRecurrence.WEEKLY); daysOfMonthEditor.setVisible(recurrenceOption == GlusterVolumeSnapshotScheduleRecurrence.MONTHLY); startAtEditor.setVisible(recurrenceOption != GlusterVolumeSnapshotScheduleRecurrence.UNKNOWN); -- To view, visit https://gerrit.ovirt.org/40005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic83e8d3a3d1505c09ab5f0d36c21b8ab1fa1d85d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
