Daniel Erez has posted comments on this change.
Change subject: webadmin: select last snapshot by default (#851094)
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
Line 79: @SuppressWarnings("unchecked")
Line 80: @Override
Line 81: public void eventRaised(Event ev, Object sender, EventArgs
args) {
Line 82: Snapshot snapshot = (Snapshot)
vmSnapshotListModel.getSelectedItem();
Line 83: // updatePanel(snapshot);
right, need to remove the listener
Line 84: }
Line 85: });
Line 86: }
Line 87:
Line 128: public String getValue(DiskImage object) {
Line 129: return object.getDiskAlias();
Line 130: }
Line 131: };
Line 132: disksTable.addColumn(aliasColumn, constants.aliasDisk());
yeah, I'll fix it separately
Line 133:
Line 134: DiskSizeColumn<DiskImage> sizeColumn = new
DiskSizeColumn<DiskImage>() {
Line 135: @Override
Line 136: protected Long getRawValue(DiskImage object) {
Line 152: protected VolumeType getRawValue(DiskImage object) {
Line 153: return
VolumeType.forValue(object.getvolume_type().getValue());
Line 154: }
Line 155: };
Line 156: disksTable.addColumn(allocationColumn,
constants.allocationDisk(), "60px"); //$NON-NLS-1$
due to description column addition
Line 157:
Line 158: TextColumnWithTooltip<DiskImage> interfaceColumn = new
TextColumnWithTooltip<DiskImage>() {
Line 159: @Override
Line 160: public String getValue(DiskImage object) {
Line 178: }
Line 179: };
Line 180: disksTable.addColumn(dateCreatedColumn,
constants.creationDateDisk(), "80px"); //$NON-NLS-1$
Line 181:
Line 182: TextColumnWithTooltip<DiskImage> descriptionColumn = new
TextColumnWithTooltip<DiskImage>() {
yeah, I'll add it separately
Line 183: @Override
Line 184: public String getValue(DiskImage object) {
Line 185: return object.getDiskDescription();
Line 186: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
Line 304: super.OnEntityChanged();
Line 305:
Line 306: if (getEntity() != null)
Line 307: {
Line 308: isEntityChanged = true;
no, the 'OnEntityChanged' event is raised only when a main-tab's entity is
changed (i.e. a VM selection).
Line 309: getSearchCommand().Execute();
Line 310: }
Line 311: }
Line 312:
--
To view, visit http://gerrit.ovirt.org/8260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09884a06615ecd2c1fdf7128f7af684a7e70a7d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
