Eli Mesika has posted comments on this change. Change subject: engine: Peer probing with alternate addresses ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40048/1/packaging/dbscripts/upgrade/03_05_1420_add_alternateprobed_gluster_server.sql File packaging/dbscripts/upgrade/03_05_1420_add_alternateprobed_gluster_server.sql: Line 1: ALTER TABLE gluster_server add column known_addresses varchar(250) null; How many addresses can be stored here and what is the max length of each ??? We must prevent a overflow here Note that if the database is running in languages that are represented in UNICODE with double byte than the effective size of this column is 125 chars -- To view, visit https://gerrit.ovirt.org/40048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fa407d6a525e73b89a79d063517798283b520fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
