Alon Bar-Lev has posted comments on this change. Change subject: host-deploy: reorg to own packages ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39976/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java: Line 183: assertTrue(commandMock.canDoAction()); Line 184: } Line 185: Line 186: @Test Line 187: @Ignore("Cannot mock the log") notice, I could not make it work as commandMock.log is protected and there is no getter, I tried to add setLog() within AddVdsCommand but it has not affect on mock. I am good disabling this test as the benefit of repackaging is great. Line 188: public void canDoActionSucceedsWhenHasPeersThrowsException() throws Exception { Line 189: setupGlusterMock(true, new VDS(), true); Line 190: when(glusterUtil.getPeers(any(EngineSSHClient.class))).thenThrow(new RuntimeException()); Line 191: assertTrue(commandMock.canDoAction()); -- To view, visit https://gerrit.ovirt.org/39976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d15cafd9337d8a2ac7cf9ee6fe0a7e182e2e30f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
