Sahina Bose has posted comments on this change. Change subject: engine: Enhance brick to support storage network ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40046/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1749: LEFT OUTER JOIN network on network.id = gluster_volume_bricks.network_id Line 1750: LEFT OUTER JOIN vds_interface ON vds_interface.vds_id = gluster_volume_bricks.server_id Line 1751: AND vds_interface.network_name = network.name; Line 1752: Line 1753: CREATE > please join this line with the one below Done Line 1754: OR REPLACE VIEW gluster_volume_task_steps AS Line 1755: SELECT Line 1756: step.*, Line 1757: gluster_volumes.id AS volume_id, https://gerrit.ovirt.org/#/c/40046/1/packaging/dbscripts/upgrade/03_05_1410_add_network_gluster_bricks.sql File packaging/dbscripts/upgrade/03_05_1410_add_network_gluster_bricks.sql: Line 1: select fn_db_add_column('gluster_volume_bricks', 'network_id', 'uuid NULL'); Line 2: Line 3: SELECT fn_db_create_constraint('gluster_volume_bricks', 'fk_gluster_volume_bricks_network_id', 'FOREIGN KEY (network_id) REFERENCES network(id)'); > please specify what is the right behavior ON DELETE it is the default behaviour, that is ON DELETE NO ACTION. Do I need to explicitly specify that? -- To view, visit https://gerrit.ovirt.org/40046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9749febf721172a09ddce756c0eeb745a9502e1a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
