Alona Kaplan has posted comments on this change. Change subject: engine: Cleanup the vfs when the vm is down and refresh host if needed ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/38624/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java: Line 23: EventResult storageDomainNotOperational(Guid storageDomainId, Guid storagePoolId); // BLL Line 24: Line 25: EventResult masterDomainNotOperational(Guid storageDomainId, Guid storagePoolId, boolean isReconstructToInactiveDomains, boolean canReconstructToCurrentMaster); // BLL Line 26: Line 27: void processOnVmStop(Collection<Guid> vmIds, Guid hostId); > can't we get the hostId from the VMs instead of adding it as parameter ever We can, but since we have just vm_ids and not the whole vm entity we'll have to query it from the db. All the places that invokes "processOnVmStop(..)" have a "free" host_id, I think it is a waste to add a redundant db query just to safe the parameter. Line 28: Line 29: boolean vdsUpEvent(VDS vds); Line 30: Line 31: boolean connectHostToDomainsInActiveOrUnknownStatus(VDS vds); -- To view, visit https://gerrit.ovirt.org/38624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f861a451f4e0961ec122e4c2594081ea6dc71b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
