Omer Frenkel has posted comments on this change. Change subject: backend: Add HostDev passthrough support #3 ......................................................................
Patch Set 35: (2 comments) https://gerrit.ovirt.org/#/c/37619/35/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AddVmHostDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AddVmHostDevicesCommand.java: Line 42: } Line 43: Line 44: @Override Line 45: public AuditLogType getAuditLogTypeValue() { Line 46: return AuditLogType.VM_ADD_HOST_DEVICES; we will have the same log for success and for failure? Line 47: } Line 48: Line 49: public List<String> getNamesAdded() { Line 50: return namesAdded; https://gerrit.ovirt.org/#/c/37619/35/packaging/dbscripts/upgrade/03_06_1240_revert_03061210_add_vm_host_device_commands.sql File packaging/dbscripts/upgrade/03_06_1240_revert_03061210_add_vm_host_device_commands.sql: Line 1 Line 2 i dont think this would work for people already used the script, wouldn't it be better to have a new script to add it? -- To view, visit https://gerrit.ovirt.org/37619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93c746cdda71678f7840d37683b890080a74341d Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
