Allon Mureinik has posted comments on this change.
Change subject: core: Introducing Business Entity comparators
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
basically +1, see inline
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityGuidComparator.java
Line 4:
Line 5: public class BusinessEntityGuidComparator<T extends
BusinessEntity<Guid>> extends BusinessEntityComparator<T, Guid> {
Line 6:
Line 7: public static <T extends BusinessEntity<Guid>>
BusinessEntityGuidComparator<T> newInstance() {
Line 8: return new BusinessEntityGuidComparator<T>();
I'd cache this (hold a static final instance)
Line 9: }
Line 10:
Line 11:
--
To view, visit http://gerrit.ovirt.org/8290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760e9266e11a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
