Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: check if host not exist under engine before add it ......................................................................
Patch Set 1: (2 comments) Thanks for the patch, some comments inside https://gerrit.ovirt.org/#/c/40102/1/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 167: def _get_host_uuid(self): Line 168: self.logger.debug('Acquiring UUID from localhost') Line 169: rc, stdout, stderr = self.execute( Line 170: (self.command.get('dmidecode'), '-s', 'system-uuid') Line 171: ) this require a change in the specfile, adding Require: dmidecode on some system it may also not work, I suggest to take a look at https://gerrit.ovirt.org/gitweb?p=ovirt-host-deploy.git;a=blob;f=src/plugins/ovirt-host-deploy/vdsm/vdsmid.py Line 172: if rc != 0: Line 173: self.logger.error( Line 174: _('Failed to retrieve uuid from localhost') Line 175: ) Line 642: ] Line 643: uuid_l = [host_hw.get_uuid() for host_hw in host_hw_l] Line 644: if h_uuid in uuid_l: Line 645: response = None Line 646: while response is None: I think that for CI we should provide a way for bypassing this dialog. Otherwise we'll need to run a job using machine interaction. Line 647: response = self.dialog.queryString( Line 648: name='OVEHOSTED_ADD_EXIST_HOST', Line 649: note=_( Line 650: 'Host with the same UUID already exists ' -- To view, visit https://gerrit.ovirt.org/40102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id46cdd877c23ac3522998c9d579330b43857bf7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
