anmolbabu has posted comments on this change. Change subject: gluster: Modified to disable the new snapshot creation ......................................................................
Patch Set 6: Code-Review+1 (1 comment) Ok so I was probably trying to +1 a old patch and hence didn't have it. Now I have it :) https://gerrit.ovirt.org/#/c/40118/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 583: may be we could avoid this in a subsequent refactoring patch. This is a repetitive check although not expensive(here and also in updateActionAvailability). Probably within if (list.size() == 1) of updateActionAvailability you could invoke isCreateSnapshotAvailable and hence avoid checking list size again here anyway the flag(in updateActionAvailability) defaults to false if not touched. May not be in this patch because this line is not edited here. -- To view, visit https://gerrit.ovirt.org/40118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ed296a6afc4dfa5f3e7023c0dc40b7da4ad4392 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
