Allon Mureinik has posted comments on this change.

Change subject: core: Include 'unattached' domains in domains for search view
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File backend/manager/dbscripts/create_views.sql
Line 291:                 storage_domain_static.storage_type as storage_type, 
storage_domain_static.storage_domain_type as storage_domain_type,
Line 292:                 storage_domain_static.storage_domain_format_type as 
storage_domain_format_type,
Line 293:                 storage_domain_static.last_time_used_as_master as 
last_time_used_as_master,
Line 294:                 CASE
Line 295:                         WHEN status_table.is_multi_domain THEN NULL
replace tabs with spaces
Line 296:                           WHEN status_table.status IS NULL THEN 2 -- 
in case domain is unattached
Line 297:                           ELSE status_table.status END as status,
Line 298:                 null as owner, null as storage_pool_id, null as 
storage_pool_name,
Line 299:                 storage_domain_dynamic.available_disk_size as 
available_disk_size,


--
To view, visit http://gerrit.ovirt.org/8315
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3faa0d0504520513ce0c565b2476779d0362edfb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to