Moti Asayag has posted comments on this change. Change subject: engine: Remove from host_device table the ids of vms which are down ......................................................................
Patch Set 6: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/39894/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java: Line 195: Line 196: // Setting an id of VM with <code>VMStatus.Down</code> Line 197: Guid vmId = FixturesTool.VM_WITH_NO_ATTACHED_DISKS; Line 198: dao.setVmIdOnHostDevice(before.getId(), vmId); Line 199: assertEquals(vmId, dao.get(before.getId()).getVmId()); please break this statement: HostDevice device = dao.get(before.getId()); assertNotNull(device); assertEquals(vmId, device.getVmId()); Line 200: Line 201: dao.cleanDownVms(); Line 202: Line 203: assertNull(dao.get(before.getId()).getVmId()); Line 199: assertEquals(vmId, dao.get(before.getId()).getVmId()); Line 200: Line 201: dao.cleanDownVms(); Line 202: Line 203: assertNull(dao.get(before.getId()).getVmId()); same. Line 204: } Line 205: Line 206: private HostDevice getNetworkDevice() { Line 207: HostDeviceId netDeviceId = -- To view, visit https://gerrit.ovirt.org/39894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I728fadd7d9d4c10f905866353e07912cc55d1c9e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Beták <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
