Dhandapani Gopal has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
......................................................................
Patch Set 2: (1 inline comment)
Responses to Selvasundaram comment in-line.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeProfileCommand.java
Line 37: @Override
Line 38: protected void executeCommand() {
Line 39: VDSReturnValue returnValue =
Line 40: runVdsCommand(VDSCommandType.StartGlusterVolumeProfile,
Line 41: new
GlusterVolumeVDSParameters(upServer.getId(), getGlusterVolumeName()));
We are handling the upServer null check in the canDoAction() of all gluster
commands. The canDoAction() will fail if there is no up server found.
Line 42: setSucceeded(returnValue.getSucceeded());
Line 43: if (!getSucceeded()) {
Line 44:
handleVdsError(AuditLogType.GLUSTER_VOLUME_PROFILE_START_FAILED,
returnValue.getVdsError().getMessage());
Line 45: return;
--
To view, visit http://gerrit.ovirt.org/8261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia47f7033f080f75a6ebf8481ea4199ee32bbf4ab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
