Martin Mucha has posted comments on this change. Change subject: webadmin: cleanup. Removed unneded hierarchy, methods, fields. ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/40034/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceTypeInterfaceCreatingManager.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceTypeInterfaceCreatingManager.java: Line 1: package org.ovirt.engine.ui.uicommonweb.models.vms; Line 2: > why did you move this class here? I'd say it should stay in the instancetyp bad refactoring; When destroying hierarchy I pushed members of this class to its parent and then renamed the parent. That led to this class landing wrong package. Moved. Done. Line 3: import java.util.ArrayList; Line 4: import java.util.List; Line 5: Line 6: import org.ovirt.engine.core.common.action.VdcActionParametersBase; Line 43: UpdateNicsTemplateInterfaceParametersFactory factory = new UpdateNicsTemplateInterfaceParametersFactory( Line 44: VnicInstanceType.getNetworkInterfaces(vnicsWithProfiles), Line 45: null, Line 46: null, Line 47: vmId, //TODO MM: this is probably actually templateId; verify that. > in this context it is instance type id renamed.Done Line 48: getNonNullExistingVnicsFromResult(result)); Line 49: Line 50: doNicManipulation(factory.createCreateVnicParameters(), Line 51: factory.createUpdateVnicParameters(), https://gerrit.ovirt.org/#/c/40034/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java: Line 4: import org.ovirt.engine.core.compat.Guid; Line 5: import org.ovirt.engine.ui.uicompat.FrontendActionAsyncResult; Line 6: import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback; Line 7: Line 8: public class UnitVmModelNetworkAsyncCallback implements IFrontendActionAsyncCallback { > since this is used only by instance types now please rename to InstanceType Done Line 9: Line 10: private final UnitVmModel unitVmModel; Line 11: private final InstanceTypeInterfaceCreatingManager networkCreatingManager; Line 12: private final Guid idToUpdate; -- To view, visit https://gerrit.ovirt.org/40034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a68250220b43cba0e115f9859e82c9bed01b5bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
