Martin Mucha has posted comments on this change. Change subject: restapi: Add setupnetworks api ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/35379/12/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 2636: body: Line 2637: parameterType: Action Line 2638: signatures: Line 2639: - mandatoryArguments: {} Line 2640: optionalArguments: { > I think that it is better to use indentation because then you don't need co no problem! It's surely matter of style but if there's just one of them it's better for everyone. I'll fix all these in these patch series. If I overlook something, please point it out and I fix it. Done. Line 2641: action.network_attachments.network_attachment--COLLECTION: { Line 2642: network_attachment.id: 'xs:string', Line 2643: network_attachment.network.id: 'xs:string', Line 2644: network_attachment.host_nic.name|id: 'xs:string', Line 2646: network_attachment.ip_configuration.ipv4s.ipv4--COLLECTION: { Line 2647: ipv4.address: 'xs:string', Line 2648: ipv4.netmask: 'xs:string', Line 2649: ipv4.gateway: 'xs:string' Line 2650: }, > Never mind, we shouldn't use a complicated API design just because the CLI Done Line 2651: network_attachment.properties.property--COLLECTION: { Line 2652: property.name: 'xs:string', Line 2653: property.value: 'xs:string' Line 2654: }, -- To view, visit https://gerrit.ovirt.org/35379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f6004956a6b0f17ef5242eb5021429949f65fe Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
