Yair Zaslavsky has posted comments on this change.
Change subject: core: ConnectHostToStoragePoolServersCommand is not called when
cluster is added to existing datacenter
......................................................................
Patch Set 1: (1 inline comment)
One typo, update error properties files accordingly.
Besides that looks fine.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 318: VDS_GROUP_CANNOT_UPDATE_CPU_WITH_LOWER_HOSTS=Cannot change Cluster
CPU to higher CPU type when there are active Hosts with lower CPU type.\n\
Line 319: -Please move Hosts with lower CPU to maintenance first.
Line 320: VDS_GROUP_CANNOT_UPDATE_COMPATIBILITY_VERSION_WITH_LOWER_HOSTS=Cannot
change Cluster Compatibility Version to higher version when there are active
Hosts with lower version.\n\
Line 321: -Please move Hosts with lower version to maintenance first.
Line 322: VDS_GROUP_CANNOT_UPDATE_VDS_UP=Cannot change Cluster.Trying to
connect Cluster to Data Center with Hosts which has status Up.
s/has/have
or:
with hosts that are up
or:
with hosts that are in up state
Line 323:
VDS_GROUP_CANNOT_ADD_COMPATIBILITY_VERSION_WITH_LOWER_STORAGE_POOL=Cannot add
Cluster with Compatibility Version that is lower than the Data Center
Compatibility Version.\n\
Line 324: -Please upgrade your Cluster to a later Compatibility version
first.
Line 325: VDS_GROUP_CPU_TYPE_CANNOT_BE_NULL=Cannot add Cluster. CPU type must
be specified
Line 326: VDS_GROUP_CANNOT_DO_ACTION_NAME_IN_USE=Cannot ${action} Cluster.
Cluster name is already in use.
--
To view, visit http://gerrit.ovirt.org/8320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05343b232f565b1b829645795bf804e246a405fd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
