Shahar Havivi has posted comments on this change.

Change subject: Engine: set Rhev-H upgrade version via config value (#842767)
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1488:     SSHInactivityHardTimoutSeconds(383),
Line 1489: 
Line 1490:     @TypeConverterAttribute(String.class)
Line 1491:     @DefaultValueAttribute("1.0.0.0")
Line 1492:     RhevHUpgradeVersion(384),
yes...,
leftover from the previous patch.
Line 1493: 
Line 1494:     Invalid(65535);
Line 1495: 
Line 1496:     private int intValue;


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
Line 5: public interface ApplicationMessages extends CommonApplicationMessages {
Line 6: 
Line 7:     // Host alert messages (not that the <a> and </a> tags are used to 
indicate the
Line 8:     // place where the link to actions should be introduced:
Line 9:     @DefaultMessage("Upgrade or reinstall RHEV Hypervisor.")
yes...
the message is the bug request from this comment:
https://bugzilla.redhat.com/show_bug.cgi?id=842767#c3
Line 10:     String hostHasUpgradeAlert();
Line 11: 
Line 12:     @DefaultMessage("This host is in non responding state. Try to 
Activate it; If the problem persists, switch Host to Maintenance mode and try 
to reinstall it.")
Line 13:     String hostHasReinstallAlertNonResponsive();


--
To view, visit http://gerrit.ovirt.org/7430
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae5263d565787ea7460f1d5f59beb77acff8b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to