Michael Pasternak has posted comments on this change.
Change subject: restapi: Attach Disk To VM - Return Disk In Response
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 52: @Override
Line 53: public Response add(Disk disk) {
Line 54: validateEnums(Disk.class, disk);
Line 55: if (disk.isSetId()) {
Line 56: return
Response.fromResponse(attachDiskToVm(disk)).entity(getDeviceSubResource(disk.getId()).get()).build();
it's CREATE-like call (which is returns resource at the end), you should reuse
create() logic only writing private by-id resolver.
Line 57: }else {
Line 58: return super.add(disk);
Line 59: }
Line 60: }
--
To view, visit http://gerrit.ovirt.org/8335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a50077886734f73842141262f5c338979dcae5c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
