Yair Zaslavsky has posted comments on this change.
Change subject: core: Validate maximum number of hosts in DC.(#771699)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
See commment +
When adding stored procedure - add test to DAO.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
Line 58: @Override
Line 59: protected void executeCommand() {
Line 60: // according to shaharf the first id is 1
Line 61: int selectedId = 1;
Line 62: List<Integer> map = LinqUtils.foreach(vds_spm_id_mapList, new
Function<vds_spm_id_map, Integer>() {
bad usage name of variable. was confusing later to read this. Don't use "map"
with a type of "List"
Try and avoid using LinqUtils, we should get rid of this.
Line 63: @Override
Line 64: public Integer eval(vds_spm_id_map vds_spm_id_map) {
Line 65: return vds_spm_id_map.getvds_spm_id();
Line 66: }
--
To view, visit http://gerrit.ovirt.org/8321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff61
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
