Moti Asayag has posted comments on this change.
Change subject: engine: Stop Gluster Volume Profile command
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeProfileCommand.java
Line 26:
addCanDoActionMessage(VdcBllMessages.VAR__TYPE__GLUSTER_VOLUME);
Line 27: }
Line 28:
Line 29: @Override
Line 30: protected boolean canDoAction() {
by the way this method is written, you can completely remove it from this
class, and the canDoAction defined on its super will be called.
Line 31: if (!super.canDoAction()) {
Line 32: return false;
Line 33: }
Line 34: return true;
Line 41: new
GlusterVolumeVDSParameters(upServer.getId(), getGlusterVolumeName()));
Line 42: setSucceeded(returnValue.getSucceeded());
Line 43: if (!getSucceeded()) {
Line 44:
handleVdsError(AuditLogType.GLUSTER_VOLUME_PROFILE_STOP_FAILED,
returnValue.getVdsError().getMessage());
Line 45: return;
the return statement is redundant here.
Line 46: }
Line 47: }
Line 48:
Line 49: @Override
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeProfileCommandTest.java
Line 25:
Line 26: @Mock
Line 27: GlusterVolumeDao volumeDao;
Line 28:
Line 29: private static final Guid startedVolumeId = new
Guid("b2cb2f73-fab3-4a42-93f0-d5e4c069a43e");
please maintain java naming convention for constants with upper case same as
did for CLUSTER_ID.
Line 30: private static final Guid stoppedVolumeId = new
Guid("8bc6f108-c0ef-43ab-ba20-ec41107220f5");
Line 31: private static final Guid CLUSTER_ID = new
Guid("b399944a-81ab-4ec5-8266-e19ba7c3c9d1");
Line 32:
Line 33: private StopGlusterVolumeProfileCommand cmd;
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 554: HA_VM_FAILED=Highly Available VM ${VmName} failed. It will be
restarted automatically.
Line 555: HA_VM_RESTART_FAILED=Restart of the Highly Available VM ${VmName}
failed.
Line 556: GLUSTER_VOLUME_PROFILE_START=Gluster volume ${glusterVolumeName}
Profile started.
Line 557: GLUSTER_VOLUME_PROFILE_START_FAILED=Could not start Gluster Volume
Profile on ${glusterVolumeName}.
Line 558: GLUSTER_VOLUME_PROFILE_STOP=Gluster volume ${glusterVolumeName}
Profile stopped.
shouldn't volume be with uppercase V ?
--
To view, visit http://gerrit.ovirt.org/8332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If776bb4369a1fa77ec8a8b2cda02fea6456101ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
