Kanagaraj M has posted comments on this change.

Change subject: webadmin: Using editable combo for volume option key
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterModel.java
Line 107:         }
Line 108: 
Line 109:         if (selectedOption != null)
Line 110:         {
Line 111:             if (selectedOption.getDescription().equals("(null)")) 
//$NON-NLS-1$
Done
Line 112:             {
Line 113:                 getDescription().setEntity(null);
Line 114:             }
Line 115:             else


Line 118:             }
Line 119: 
Line 120:             if (getIsNew())
Line 121:             {
Line 122:                 if 
(selectedOption.getDefaultValue().equals("(null)")) //$NON-NLS-1$
Done
Line 123:                 {
Line 124:                     getValue().setEntity(null);
Line 125:                 }
Line 126:                 else


--
To view, visit http://gerrit.ovirt.org/8184
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48ac5232d95dc01b9f38160c00e37c02dcd44f0a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to