Omer Frenkel has posted comments on this change. Change subject: events: vm stats refresher refactioring ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/37487/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java: Line 47: Line 48: @Override Line 49: @OnTimerMethodAnnotation("perform") Line 50: public void perform() { Line 51: if (this.manager.isMonitoringNeeded()) { > Can you tell me the advantage to use one over the other? A manager object i as i said its more of a style, but thumb rule is that it is not needed, unless, as you said, there is shadowing in the method, and here we dont have it, so its not needed. its not a mistake, its just not common to use it without a reason (which is the method has a parameter with the same name that shadows the class member) Line 52: VmsListFetcher fetcher = Line 53: getRefreshStatistics() ? Line 54: new VmsStatisticsFetcher(this.manager) : Line 55: new VmsListFetcher(this.manager); -- To view, visit https://gerrit.ovirt.org/37487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
