Yevgeny Zaspitsky has posted comments on this change. Change subject: core: using JPA for engine backup awareness ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/40091/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineBackupLogDaoDbFacadeImpl.java: Line 21: TypedQuery TypedQuery, as its name reminds, is parameterized, so please use TypedQuery<EngineBackupLog>. Line 18: Line 19: @Override Line 20: public EngineBackupLog getLastSuccessfulEngineBackup(String dbName) { Line 21: TypedQuery query = entityManager.createNamedQuery("EngineBackupLog.getLatest", EngineBackupLog.class).setParameter("dbName", dbName); Line 22: query.setMaxResults(1); +1 Moti You might add .setMaxResult at the end, just format that so the line will be split. Line 23: EngineBackupLog log = singleResult(query); Line 24: return log; Line 25: } -- To view, visit https://gerrit.ovirt.org/40091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0aa9c4d0c8c0a5f7b40a022d7670f30c5fd5b77 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
