Martin Peřina has posted comments on this change. Change subject: core: Fix CDI in dal module to work with EAP/WildFly ......................................................................
Patch Set 3: @New is deprecated in CDI 1.1. I tried to use @Named without specific name on producer method DbFacadeLocator.produceDbEngineDialect(), but it doesn't resolve ambiguity between producer method and default parameter-less constructor. And I definitely don't want to move to @Name(value="Postgres...") annotation because we would loose ability to change db dialect using configuration file. Also because we are using producer method we can execute different constructors for different implementations of DbEngineDialect if needed. I added PostgresDbEngineDialect(boolean) because I needed constructor with parameters and this was the easiest one, but we can add a different one if needed. So for now (until we move to EAP 7 downstream -> CDI 1.1) I would stick with current solution. Do you agree? -- To view, visit https://gerrit.ovirt.org/40151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I122b02f846cfbb9b861d13792790cf93ca7ee0d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
