Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: pki: renew about to expire certificates
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40330/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py:

Line 225:                 'name': 'reports',
Line 226:                 'extract': True,
Line 227:                 'user': oengcommcons.SystemEnv.USER_ROOT,
Line 228:                 'keepKey': False,
Line 229:             },
not sure I understand why reports enrollment is done here and/or why key should 
be stored as plain.
Line 230:         ):
Line 231:             self.logger.debug(
Line 232:                 "processing: '%s'[renew=%s]",
Line 233:                 entry['name'],


-- 
To view, visit https://gerrit.ovirt.org/40330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6383b29e131d65cece96e298bb2c7fe6ae305afe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to