Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40331
to review the following change.
Change subject: core: Refactoring in AddVmFromTemplateCommand.canDoAction()
......................................................................
core: Refactoring in AddVmFromTemplateCommand.canDoAction()
Removed redundant reference to diskInfoDestinationMap.
Change-Id: Ib621adcc77c09e9ec532312a18cdb2bc5b5c8a7f
Signed-off-by: Shmuel Melamud <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/40331/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
index f007c74..c494fd3 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
@@ -142,9 +142,10 @@
}
for (DiskImage dit : getVmTemplate().getDiskTemplateMap().values()) {
- if
(!ImagesHandler.checkImageConfiguration(destStorages.get(diskInfoDestinationMap.get(dit.getId()).getStorageIds().get(0))
- .getStorageStaticData(),
- diskInfoDestinationMap.get(dit.getId()),
+ DiskImage diskImage = diskInfoDestinationMap.get(dit.getId());
+ if (!ImagesHandler.checkImageConfiguration(
+
destStorages.get(diskImage.getStorageIds().get(0)).getStorageStaticData(),
+ diskImage,
getReturnValue().getCanDoActionMessages())) {
return false;
}
--
To view, visit https://gerrit.ovirt.org/40331
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib621adcc77c09e9ec532312a18cdb2bc5b5c8a7f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <[email protected]>
Gerrit-Reviewer: Shmuel Melamud <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
