Martin Peřina has posted comments on this change. Change subject: core: using JPA for engine backup awareness ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/40091/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java: Line 90: if (!(obj instanceof EngineBackupLog)) { Line 91: return false; Line 92: } Line 93: EngineBackupLog other = (EngineBackupLog) obj; Line 94: return (Objects.equals(dbName, other.dbName) When we are moving to JPA, IMHO we should fix our entities' equals() and hascode() methods in a way that only primary key is used in those methods. From my previous hibernate and JPA experience, this is the only way how to implement those properly. Line 95: && Objects.equals(doneAt, other.doneAt) Line 96: && this.passed == other.passed Line 97: && Objects.equals(outputMessage, other.outputMessage)); Line 98: } -- To view, visit https://gerrit.ovirt.org/40091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0aa9c4d0c8c0a5f7b40a022d7670f30c5fd5b77 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
