Lior Vernia has posted comments on this change.

Change subject: webadmin: edit panel for sriov enabled nics
......................................................................


Patch Set 29:

(1 comment)

https://gerrit.ovirt.org/#/c/36259/29/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java:

Line 47:     @Ignore
Line 48:     NicLabelWidget labelsWidget;
Line 49: 
Line 50:     @Inject
Line 51:     public HostNicPopupView(EventBus eventBus, ApplicationConstants 
constants) {
Notice that there's a new convention on how to inject these assets - take a 
look at how other views use AssetProvider.
Line 52:         super(eventBus);
Line 53:         initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 54:         localize(constants);
Line 55:         driver.initialize(this);


-- 
To view, visit https://gerrit.ovirt.org/36259
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72f82871b3ea7a90ec68d2779c4e835cdac2c692
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to