Michael Kublin has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
......................................................................
Patch Set 11: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 200: VDSCommandType.RefreshStoragePool,
Line 201: new
RefreshStoragePoolVDSCommandParameters(vds.getId(),
Line 202: getStoragePool().getId(),
Line 203: _newMasterStorageDomainId,
Line 204:
getStoragePool().getmaster_domain_version()));
protected VDSReturnValue runVdsCommand(VDSCommandType commandType,
VDSParametersBase parameters)
throws VdcBLLException;
why you are catching VDSExceptionBase ?
Line 205: } catch (VDSExceptionBase ex) {
Line 206: if (VdcBllErrors.StoragePoolUnknown ==
ex.getVdsError().getCode()) {
Line 207: VDSReturnValue returnVal = runVdsCommand(
Line 208: VDSCommandType.ConnectStoragePool,
--
To view, visit http://gerrit.ovirt.org/7137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b1b6c32ecb1c0d3c0a9ef14beef333e442c6ccf
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
