Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 28: (1 comment) https://gerrit.ovirt.org/#/c/37886/28/packaging/bin/ovirt-engine-extensions-tool.sh File packaging/bin/ovirt-engine-extensions-tool.sh: Line 29: -Dorg.ovirt.engine.exttool.core.packageName="${PACKAGE_NAME}" \ Line 30: -Dorg.ovirt.engine.exttool.core.packageVersion="${PACKAGE_VERSION}" \ Line 31: -Dorg.ovirt.engine.exttool.core.packageDisplayName="${PACKAGE_DISPLAY_NAME}" \ Line 32: -Dorg.ovirt.engine.exttool.core.engineEtc="${ENGINE_ETC}" \ Line 33: -Dorg.ovirt.engine.exttool.core.defaultLogLevel="INFO" \ this should not be system property but environment. two choices: -Dorg.ovirt.engine.exttool.core.defaultLogLevel="${OVIRT_LOGGING_LEVEL:-INFO}" or use: System.getenv("OVIRT_LOGGING_LEVEL") without enable use of environment user cannot control this. Line 34: -jar "${JBOSS_HOME}/jboss-modules.jar" \ Line 35: -dependencies org.ovirt.engine.core.extension-tool \ Line 36: -class org.ovirt.engine.exttool.core.ExtensionsToolExecutor \ -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ondra Machacek <[email protected]> Gerrit-Reviewer: Ondřej Macháček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
