David Caro has posted comments on this change. Change subject: support .repo overrides ......................................................................
Patch Set 17: (2 comments) https://gerrit.ovirt.org/#/c/39534/17/ovirt-release-master/configure.ac File ovirt-release-master/configure.ac: Line 32: Line 33: OVIRT_SLOT="master" Line 34: AC_SUBST([OVIRT_SLOT]) Line 35: Line 36: AC_ARG_WITH([ovirt-yum-repo],[AC_HELP_STRING([--with-ovirt-yum-repo], > Do you mean you prefer long long lines? no, I mean putting one and only one parameter per line, instead of having some lines with one and some with two Line 37: [Specify yum repo, defaults to: http://resources.ovirt.org/])], Line 38: [OVIRT_YUM_REPO="$withval"], Line 39: [OVIRT_YUM_REPO="http://resources.ovirt.org";]) Line 40: AC_SUBST([OVIRT_YUM_REPO]) https://gerrit.ovirt.org/#/c/39534/17/ovirt-release-master/ovirt-release-master.spec.in File ovirt-release-master/ovirt-release-master.spec.in: Line 80: fi Line 81: Line 82: if [[ "${DISTVER}" == "el6" ]]; then Line 83: install -m 644 "%{_datadir}/%{package_name}/ovirt-el6-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo" Line 84: elif [[ "${DISTVER/.*/}" =~ ^el7 ]]; then > tested with sh, bash, zsh and ksh. I'm just not sure which shell the rpm scripts run on, if you verified is ok Line 85: # On CentOS 7 ${DISTVER} is "el7.centos" Line 86: install -m 644 "%{_datadir}/%{package_name}/ovirt-el7-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo" Line 87: elif [[ "${DISTVER}" == "fc20" ]]; then Line 88: install -m 644 "%{_datadir}/%{package_name}/ovirt-f20-deps.repo" "%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo" -- To view, visit https://gerrit.ovirt.org/39534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0453fb472d80a190278a0ffbae4371ad724b4c46 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Max Kovgan <[email protected]> Gerrit-Reviewer: Barak Korren <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Max Kovgan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
